Fix disabling NAT gateway creation for cluster role subnets
#5816
Conversation
Signed-off-by: cpu1 <[email protected]>
k8s-ci-robot
added
release-note
The committers listed above are authorized under a signed CLA. |
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @cPu1! |
k8s-ci-robot
added
needs-ok-to-test
|
Hi @cPu1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
cncf-cla: yes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5816 +/- ##
==========================================
+ Coverage 52.93% 53.06% +0.13%
==========================================
Files 279 279
Lines 29666 29678 +12
==========================================
+ Hits 15704 15750 +46
+ Misses 13149 13112 -37
- Partials 813 816 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/test ls |
|
@jackfrancis: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-provider-azure-apiserver-ilb |
|
/lgtm /hold for tests |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9d8d0f2186bee5179e651272893d1fb9ec2eb77f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@cPu1: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@mboersma here's another repro of failed capi-e2e, seems like this broke yesterday (though I don't see any obvious changes to CAPZ @ main that would be responsible) |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
3 participants
What type of PR is this?
/kind bug
What this PR does / why we need it:
When creating an
AzureClusterwith a pre-existing single subnet shared by both control plane and worker nodes (role: cluster), the AzureCluster reconciler attempts to erroneously create a NAT gateway, eventually failing with apublicips failed to create or update. err: failed to get existing resource (service: publicips): parameter publicIPAddressName cannot be emptyerror.This is a result of the defaulting webhook always setting the NAT gateway name even when a subnet ID is specified, resulting in an empty
NATGatewayIP.Name.The webhook updates this
networkSpecto
This changelist fixes the issue by setting a default NAT Gateway name only when
subnet.IDis empty.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5815
TODOs:
Release note: